Re: [PATCH v2 24/32] target/mips: Convert MSA ELM instruction format to decodetree

[Richard Henderson]

On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote:
> +static bool trans_msa_elm_df(DisasContext *ctx, arg_msa_elm_df *a,
> +                             gen_helper_piiii *gen_msa_elm_df)
> +{
> +    if (a->df < 0) {
> +        return false;
> +    }
> +
> +    gen_msa_elm_df(cpu_env,
> +                   tcg_constant_i32(a->df),
> +                   tcg_constant_i32(a->wd),
> +                   tcg_constant_i32(a->ws),
> +                   tcg_constant_i32(a->n));
> +
> +    return true;
> +}
> +
> +TRANS_MSA(SLDI,     trans_msa_elm_df, gen_helper_msa_sldi_df);

This suffers from the same test ordering problem as in patch 10.


r~