Re: [PATCH v4 03/17] target/riscv: additional macros to check instructio

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 03/17] target/riscv: additional macros to check instructio

From:	Richard Henderson
Subject:	Re: [PATCH v4 03/17] target/riscv: additional macros to check instruction support
Date:	Sat, 30 Oct 2021 16:49:58 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/25/21 5:28 AM, Frédéric Pétrot wrote:

+#define REQUIRE_64BIT(ctx) do {     \
+    if (get_xl(ctx) !=  MXL_RV64) { \


Extra space after =.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 00/17] Adding partial support for 128-bit riscv target, Frédéric Pétrot, 2021/10/25
- [PATCH v4 07/17] target/riscv: moving some insns close to similar insns, Frédéric Pétrot, 2021/10/25
  - Re: [PATCH v4 07/17] target/riscv: moving some insns close to similar insns, Philippe Mathieu-Daudé, 2021/10/25
- [PATCH v4 03/17] target/riscv: additional macros to check instruction support, Frédéric Pétrot, 2021/10/25
  - Re: [PATCH v4 03/17] target/riscv: additional macros to check instruction support, Richard Henderson <=
- [PATCH v4 01/17] exec/memop: Rename MO_Q definition as MO_UQ and add MO_UO, Frédéric Pétrot, 2021/10/25
  - Re: [PATCH v4 01/17] exec/memop: Rename MO_Q definition as MO_UQ and add MO_UO, Richard Henderson, 2021/10/25
- [PATCH v4 05/17] target/riscv: array for the 64 upper bits of 128-bit registers, Frédéric Pétrot, 2021/10/25
  - Re: [PATCH v4 05/17] target/riscv: array for the 64 upper bits of 128-bit registers, Philippe Mathieu-Daudé, 2021/10/25
  - Re: [PATCH v4 05/17] target/riscv: array for the 64 upper bits of 128-bit registers, Richard Henderson, 2021/10/25
- [PATCH v4 02/17] qemu/int128: addition of a few 128-bit operations, Frédéric Pétrot, 2021/10/25
  - Re: [PATCH v4 02/17] qemu/int128: addition of a few 128-bit operations, Philippe Mathieu-Daudé, 2021/10/25
    - Re: [PATCH v4 02/17] qemu/int128: addition of a few 128-bit operations, Richard Henderson, 2021/10/25
- [PATCH v4 06/17] target/riscv: setup everything so that riscv128-softmmu compiles, Frédéric Pétrot, 2021/10/25
  - Re: [PATCH v4 06/17] target/riscv: setup everything so that riscv128-softmmu compiles, Richard Henderson, 2021/10/30

Prev by Date: Re: [PATCH v3 5/5] target/arm: Use tcg_constant_i32() in gen_rev16()
Next by Date: Re: [PATCH v4 06/17] target/riscv: setup everything so that riscv128-softmmu compiles
Previous by thread: [PATCH v4 03/17] target/riscv: additional macros to check instruction support
Next by thread: [PATCH v4 01/17] exec/memop: Rename MO_Q definition as MO_UQ and add MO_UO
Index(es):
- Date
- Thread