[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-6.2] migration: fix dump-vmstate with modules
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH-for-6.2] migration: fix dump-vmstate with modules |
Date: |
Tue, 16 Nov 2021 09:19:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/16/21 08:28, Laurent Vivier wrote:
> To work correctly -dump-vmstate and vmstate-static-checker.py need to
> dump all the supported vmstates.
>
> But as some devices can be modules, they are not loaded at startup and not
> dumped. Fix that by loading all available modules before dumping the
> machine vmstate.
>
> Fixes: 7ab6e7fcce97 ("qdev: device module support")
> Cc: kraxel@redhat.com
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> softmmu/vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 1159a64bce4e..620a1f1367e2 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -3766,6 +3766,7 @@ void qemu_init(int argc, char **argv, char **envp)
>
> if (vmstate_dump_file) {
> /* dump and exit */
> + module_load_qom_all();
> dump_vmstate_json_to_file(vmstate_dump_file);
> exit(0);
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>