Re: [PATCH] linux-user: move target_signal.h generic definitions to generic/signal.h

[gaosong]

    Hi,

On 2021/11/25 下午6:08, WANG Xuerui wrote:

> > +
> > +#define TARGET_MINSIGSTKSZ     2048
> >       
> While all the architectures you de-duplicated here have
> TARGET_MINSIGSTACKSZ as 2048, some others specify a different value
> (mostly 4096, e.g. alpha), as can be seen in your next patch (which
> should belong to this series, btw).
>     
    Surely   I 'll add a patch to delete TARGET_SIGSTKSZ.
>  Do you mean to change semantics
> here? Or you might have to allow arches to override this value.
>
>
>     
    mips64, sparc, alpha, mips, hppa, their signal definitions are
    defined in /linux-user/XXX/target_signal.h, 
    but their target_signal.h don't include generic/signal.h.  they
    don't use generic/signal.h at all.  
    It's hard to move their some generic definitions to
    generic/signal.h,  because their definitions are too defferent with
    generic.
      
    Thanks
    Song Gao