Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

[Hyman]

在 2021/12/24 13:14, Peter Xu 写道:
> On Tue, Dec 14, 2021 at 07:07:34PM +0800, huangy81@chinatelecom.cn wrote:
> > +void qmp_vcpu_dirty_limit(bool enable,
> > +                          bool has_cpu_index,
> > +                          uint64_t cpu_index,
> > +                          bool has_dirty_rate,
> > +                          uint64_t dirty_rate,
> > +                          Error **errp)
> > +{
> > +    static bool initialized;
>
> IMHO this is not needed; if we're with a global state pointer then it's the
> same to check against that.
Sound good, this make code simpler.
> The rest looks mostly good (besides the last proposal on API design which you
> got confirmation from Markus).