Re: [PATCH] tests/qtest/test-x86-cpuid-compat: Check for machines before using them

[Thomas Huth]

On 27/12/2021 11.01, Igor Mammedov wrote:
> On Wed, 22 Dec 2021 16:39:23 +0100
> Thomas Huth <thuth@redhat.com> wrote:
>
> > The user might have disabled the pc-i440fx machine type (or it's older
> > versions, like done in downstream RHEL) in the QEMU binary, so let's
> > better check whether the machine types are available before using them.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> Looks good to me, so
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
>
> the only concern is that when deprecated machine is removed,
> this code will happily hide test block which should be removed.

Yes, but ideally, the person who removes depreacted machines should "grep" 
throught the sources for the machines that should be removed anyway 
(otherwise you might miss the spots where they are mentioned in comments 
anyway, like in hw/i386/acpi-build.c for example).

By the way, currently there are no x86 machines marked as deprecated ... 
should we maybe mark the pc-i440fx-1.x machines as deprecated now, since 
they are very old already?

 Thomas