qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type


From: Greg Kroah-Hartman
Subject: Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type
Date: Thu, 6 Jan 2022 14:25:32 +0100

On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field.  Move the firmware qemu_fw_cfg sysfs code to use default_groups
> > field which has been the preferred way since aa30f47cf666 ("kobject: Add
> > support for default attribute groups to kobj_type") so that we can soon
> > get rid of the obsolete default_attrs field.
> > 
> > Cc: Gabriel Somlo <somlo@cmu.edu>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> OK then you know best I guess
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 
> feel free to queue.

Thanks, will do!

greg k-h



reply via email to

[Prev in Thread] Current Thread [Next in Thread]