|
| From: | Thomas Huth |
| Subject: | test_isa_retry_flush() in ide-test.c |
| Date: | Fri, 7 Jan 2022 17:01:36 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
Hi John!I just notice that test_isa_retry_flush() is not doing anything useful anymore: It likely was supposed to run the test_retry_flush() function with the "isapc" machine type, but actually test_retry_flush() ignores the machine option parameter completely and always uses PCI accessor functions nowadays (since commit 9c268f8ae84ae186). Question is: Is it worth the effort to try to restore the original intended behavior for the ISA test here, or shall we rather simply remove it instead to save some testing cycles?
Thomas
| [Prev in Thread] | Current Thread | [Next in Thread] |