qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v14 16/26] target/loongarch: Add disassembler


From: Richard Henderson
Subject: Re: [PATCH v14 16/26] target/loongarch: Add disassembler
Date: Sun, 9 Jan 2022 10:51:09 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 1/9/22 1:25 AM, WANG Xuerui wrote:
+static inline int shl_2(DisasContext *ctx, int x)
+{
+    return x * 4;
Although "<< 2" has the same effect as "* 4" here, isn't "<< 2" better in matching the function name?

Yes, good point.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]