[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 05/10] Revert "virtio: add support for configure interrupt"
|
From: |
Michael S. Tsirkin |
|
Subject: |
[PULL v2 05/10] Revert "virtio: add support for configure interrupt" |
|
Date: |
Mon, 10 Jan 2022 16:04:59 -0500 |
This reverts commit 081f864f56307551f59c5e934e3f30a7290d0faa.
Fixes: 081f864f56 ("virtio: add support for configure interrupt")
Cc: "Cindy Lu" <lulu@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/virtio/virtio.h | 4 ----
hw/virtio/virtio.c | 29 -----------------------------
2 files changed, 33 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index d78088d872..605ea79c90 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -111,7 +111,6 @@ struct VirtIODevice
bool use_guest_notifier_mask;
AddressSpace *dma_as;
QLIST_HEAD(, VirtQueue) *vector_queues;
- EventNotifier config_notifier;
};
struct VirtioDeviceClass {
@@ -314,14 +313,11 @@ uint16_t virtio_get_queue_index(VirtQueue *vq);
EventNotifier *virtio_queue_get_guest_notifier(VirtQueue *vq);
void virtio_queue_set_guest_notifier_fd_handler(VirtQueue *vq, bool assign,
bool with_irqfd);
-void virtio_config_set_guest_notifier_fd_handler(VirtIODevice *vdev,
- bool assign, bool with_irqfd);
int virtio_device_start_ioeventfd(VirtIODevice *vdev);
int virtio_device_grab_ioeventfd(VirtIODevice *vdev);
void virtio_device_release_ioeventfd(VirtIODevice *vdev);
bool virtio_device_ioeventfd_enabled(VirtIODevice *vdev);
EventNotifier *virtio_queue_get_host_notifier(VirtQueue *vq);
-EventNotifier *virtio_config_get_guest_notifier(VirtIODevice *vdev);
void virtio_queue_set_host_notifier_enabled(VirtQueue *vq, bool enabled);
void virtio_queue_host_notifier_read(EventNotifier *n);
void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 971e59a663..5d18868d7d 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3494,14 +3494,7 @@ static void
virtio_queue_guest_notifier_read(EventNotifier *n)
virtio_irq(vq);
}
}
-static void virtio_config_guest_notifier_read(EventNotifier *n)
-{
- VirtIODevice *vdev = container_of(n, VirtIODevice, config_notifier);
- if (event_notifier_test_and_clear(n)) {
- virtio_notify_config(vdev);
- }
-}
void virtio_queue_set_guest_notifier_fd_handler(VirtQueue *vq, bool assign,
bool with_irqfd)
{
@@ -3518,23 +3511,6 @@ void
virtio_queue_set_guest_notifier_fd_handler(VirtQueue *vq, bool assign,
}
}
-void virtio_config_set_guest_notifier_fd_handler(VirtIODevice *vdev,
- bool assign, bool with_irqfd)
-{
- EventNotifier *n;
- n = &vdev->config_notifier;
- if (assign && !with_irqfd) {
- event_notifier_set_handler(n, virtio_config_guest_notifier_read);
- } else {
- event_notifier_set_handler(n, NULL);
- }
- if (!assign) {
- /* Test and clear notifier before closing it,*/
- /* in case poll callback didn't have time to run. */
- virtio_config_guest_notifier_read(n);
- }
-}
-
EventNotifier *virtio_queue_get_guest_notifier(VirtQueue *vq)
{
return &vq->guest_notifier;
@@ -3608,11 +3584,6 @@ EventNotifier *virtio_queue_get_host_notifier(VirtQueue
*vq)
return &vq->host_notifier;
}
-EventNotifier *virtio_config_get_guest_notifier(VirtIODevice *vdev)
-{
- return &vdev->config_notifier;
-}
-
void virtio_queue_set_host_notifier_enabled(VirtQueue *vq, bool enabled)
{
vq->host_notifier_enabled = enabled;
--
MST
- [PULL v2 00/10] virtio: revert config interrupt changes, Michael S. Tsirkin, 2022/01/10
- [PULL v2 01/10] Revert "virtio-pci: add support for configure interrupt", Michael S. Tsirkin, 2022/01/10
- [PULL v2 03/10] Revert "virtio-net: add support for configure interrupt", Michael S. Tsirkin, 2022/01/10
- [PULL v2 02/10] Revert "virtio-mmio: add support for configure interrupt", Michael S. Tsirkin, 2022/01/10
- [PULL v2 04/10] Revert "vhost: add support for configure interrupt", Michael S. Tsirkin, 2022/01/10
- [PULL v2 05/10] Revert "virtio: add support for configure interrupt",
Michael S. Tsirkin <=
- [PULL v2 10/10] Revert "virtio: introduce macro IRTIO_CONFIG_IRQ_IDX", Michael S. Tsirkin, 2022/01/10
- [PULL v2 07/10] Revert "vhost: introduce new VhostOps vhost_set_config_call", Michael S. Tsirkin, 2022/01/10
- [PULL v2 09/10] Revert "virtio-pci: decouple notifier from interrupt process", Michael S. Tsirkin, 2022/01/10
- [PULL v2 06/10] Revert "vhost-vdpa: add support for config interrupt", Michael S. Tsirkin, 2022/01/10
- [PULL v2 08/10] Revert "virtio-pci: decouple the single vector from the interrupt process", Michael S. Tsirkin, 2022/01/10
- Re: [PULL v2 00/10] virtio: revert config interrupt changes, Peter Maydell, 2022/01/11