Re: [RFC PATCH v3 7/7] gitlab-ci: Support macOS 12 via cirrus-run

[Philippe Mathieu-Daudé]

On 13/1/22 08:39, Thomas Huth wrote:
> On 10/01/2022 14.10, Philippe Mathieu-Daudé wrote:
> > Add support for macOS 12 build on Cirrus-CI, similarly to commit
> > 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run").
> >
> > Update the lcitool repository to get the macos12 mappings,
> > and generate the vars file by calling 'make lcitool-refresh'.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > Pending on libvirt-ci MR #210:
> > https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/210
> > ---
> >   .gitlab-ci.d/cirrus.yml           | 15 +++++++++++++++
> >   .gitlab-ci.d/cirrus/macos-12.vars | 16 ++++++++++++++++
> >   tests/lcitool/libvirt-ci          |  2 +-
> >   tests/lcitool/refresh             |  1 +
> >   4 files changed, 33 insertions(+), 1 deletion(-)
> >   create mode 100644 .gitlab-ci.d/cirrus/macos-12.vars
> >
> > diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
> > index b96b22e2697..b7662959070 100644
> > --- a/.gitlab-ci.d/cirrus.yml
> > +++ b/.gitlab-ci.d/cirrus.yml
> > @@ -87,6 +87,21 @@ x64-macos-11-base-build:
> >       PKG_CONFIG_PATH: 
> > /usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/ncurses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig 
> >
> >       TEST_TARGETS: check-unit check-block check-qapi-schema 
> > check-softfloat check-qtest-x86_64
> > +x64-macos-12-base-build:
> > +  extends: .cirrus_build_job
> > +  variables:
> > +    NAME: macos-12
> > +    CIRRUS_VM_INSTANCE_TYPE: osx_instance
> > +    CIRRUS_VM_IMAGE_SELECTOR: image
> > +    CIRRUS_VM_IMAGE_NAME: monterey-base
> > +    CIRRUS_VM_CPUS: 12
> > +    CIRRUS_VM_RAM: 24G
> > +    UPDATE_COMMAND: brew update
> > +    INSTALL_COMMAND: brew install
> > +    PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext/bin
> > +    PKG_CONFIG_PATH: 
> > /usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/ncurses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig 
> >
> > +    TEST_TARGETS: check-unit check-block check-qapi-schema 
> > check-softfloat check-qtest-x86_64
>
> Since we cannot run that many Cirrus-CI jobs in parallel, I think it 
> might make sense to limit the macos-11 job to manual mode now?

TBH I don't know, IIUC macOS seems somehow a bit tied with hardware
(updated less often), and apparently our user base is still interested
in having the previous Catalina version working too.

What about FreeBSD jobs? Do you also plan to set the FreeBSD 12 job to 
manual?

Maybe we could split the configured options, but I'm not sure we'll save
much, the basics to be covered are major sysemu with ui, tools & doc.