Re: [PATCH 20/30] bsd-user/signal.c: core_dump_signal

[Peter Maydell]

On Thu, 13 Jan 2022 at 20:28, Warner Losh <imp@bsdimp.com> wrote:
> On Thu, Jan 13, 2022 at 1:22 PM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
>> Code is fine, but since this is a static function with no callers
>> the compiler is going to emit a warning about that. It's a small
>> function, so the easiest thing is just to squash this into the
>> following patch which is what adds the code that calls it.
>
>
> Sure thing. I'm still trying to get a feel for right-sizing the chunking...
> Since the warning didn't fail the compile, I thought it would be OK,
> but can easily fold this in with the first patch to use it.

Ah yes, we don't currently default-enable -Werror for BSD hosts
in configure (only for Linux and for mingw32). So in this particular
case it doesn't matter much, but we might as well do it the way we would
for code that's not BSD-specific.

thanks
-- PMM