[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/20] jackaudio: use ifdefs to hide unavailable functions
|
From: |
Gerd Hoffmann |
|
Subject: |
[PULL 04/20] jackaudio: use ifdefs to hide unavailable functions |
|
Date: |
Fri, 14 Jan 2022 07:53:10 +0100 |
From: Volker RĂ¼melin <vr_qemu@t-online.de>
On Windows the jack_set_thread_creator() function and on MacOS the
pthread_setname_np() function with a thread pointer paramater is
not available. Use #ifdefs to remove the jack_set_thread_creator()
function call and the qjack_thread_creator() function in both
cases.
The qjack_thread_creator() function just sets the name of the
created thread for debugging purposes and isn't really necessary.
>From the jack_set_thread_creator() documentation:
(...)
No normal application/client should consider calling this. (...)
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/785
Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <20211226154017.6067-1-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/jackaudio.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index e7de6d5433e9..317009e93660 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -622,6 +622,7 @@ static void qjack_enable_in(HWVoiceIn *hw, bool enable)
ji->c.enabled = enable;
}
+#if !defined(WIN32) && defined(CONFIG_PTHREAD_SETNAME_NP_W_TID)
static int qjack_thread_creator(jack_native_thread_t *thread,
const pthread_attr_t *attr, void *(*function)(void *), void *arg)
{
@@ -635,6 +636,7 @@ static int qjack_thread_creator(jack_native_thread_t
*thread,
return ret;
}
+#endif
static void *qjack_init(Audiodev *dev)
{
@@ -687,7 +689,9 @@ static void register_audio_jack(void)
{
qemu_mutex_init(&qjack_shutdown_lock);
audio_driver_register(&jack_driver);
+#if !defined(WIN32) && defined(CONFIG_PTHREAD_SETNAME_NP_W_TID)
jack_set_thread_creator(qjack_thread_creator);
+#endif
jack_set_error_function(qjack_error);
jack_set_info_function(qjack_info);
}
--
2.34.1
- [PULL 00/20] Kraxel 20220114 patches, Gerd Hoffmann, 2022/01/14
- [PULL 01/20] hw/usb/dev-wacom: add missing HID descriptor, Gerd Hoffmann, 2022/01/14
- [PULL 02/20] usb: allow max 8192 bytes for desc, Gerd Hoffmann, 2022/01/14
- [PULL 03/20] ui/vnc.c: Fixed a deadlock bug., Gerd Hoffmann, 2022/01/14
- [PULL 05/20] dsoundaudio: fix crackling audio recordings, Gerd Hoffmann, 2022/01/14
- [PULL 08/20] ui: fix gtk clipboard clear assertion, Gerd Hoffmann, 2022/01/14
- [PULL 10/20] hw/display: Rename VGA_ISA_MM -> VGA_MMIO, Gerd Hoffmann, 2022/01/14
- [PULL 04/20] jackaudio: use ifdefs to hide unavailable functions,
Gerd Hoffmann <=
- [PULL 09/20] uas: add missing return, Gerd Hoffmann, 2022/01/14
- [PULL 06/20] hw/audio/intel-hda: fix stream reset, Gerd Hoffmann, 2022/01/14
- [PULL 11/20] hw/display/vga-mmio: Inline vga_mm_init(), Gerd Hoffmann, 2022/01/14
- [PULL 12/20] hw/display/vga-mmio: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO, Gerd Hoffmann, 2022/01/14
- [PULL 15/20] edid: Added support for 4k@60 Hz monitor, Gerd Hoffmann, 2022/01/14
- [PULL 20/20] ui/input-legacy: pass horizontal scroll information, Gerd Hoffmann, 2022/01/14
- [PULL 07/20] ui/dbus: fix buffer-overflow detected by ASAN, Gerd Hoffmann, 2022/01/14
- [PULL 13/20] hw/mips/jazz: Inline vga_mmio_init() and remove it, Gerd Hoffmann, 2022/01/14
- [PULL 17/20] ui/cocoa: pass horizontal scroll information to the device code, Gerd Hoffmann, 2022/01/14
- [PULL 14/20] edid: set default resolution to 1280x800 (WXGA), Gerd Hoffmann, 2022/01/14