[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 6/6] hw/arm/virt: Drop superfluous checks against highmem
|
From: |
Marc Zyngier |
|
Subject: |
[PATCH v5 6/6] hw/arm/virt: Drop superfluous checks against highmem |
|
Date: |
Fri, 14 Jan 2022 14:07:41 +0000 |
Now that the devices present in the extended memory map are checked
against the available PA space and disabled when they don't fit,
there is no need to keep the same checks against highmem, as
highmem really is a shortcut for the PA space being 32bit.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
hw/arm/virt-acpi-build.c | 2 --
hw/arm/virt.c | 5 +----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 0757c28f69..449fab0080 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -947,8 +947,6 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables
*tables)
acpi_add_table(table_offsets, tables_blob);
build_fadt_rev5(tables_blob, tables->linker, vms, dsdt);
- vms->highmem_redists &= vms->highmem;
-
acpi_add_table(table_offsets, tables_blob);
build_madt(tables_blob, tables->linker, vms);
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 053791cc44..4524f3807d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2171,9 +2171,6 @@ static void machvirt_init(MachineState *machine)
virt_flash_fdt(vms, sysmem, secure_sysmem ?: sysmem);
- vms->highmem_mmio &= vms->highmem;
- vms->highmem_redists &= vms->highmem;
-
create_gic(vms, sysmem);
virt_cpu_post_init(vms, sysmem);
@@ -2192,7 +2189,7 @@ static void machvirt_init(MachineState *machine)
machine->ram_size, "mach-virt.tag");
}
- vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64);
+ vms->highmem_ecam &= (!firmware_loaded || aarch64);
create_rtc(vms);
--
2.30.2
- [PATCH v5 0/6] target/arm: Reduced-IPA space and highmem fixes, Marc Zyngier, 2022/01/14
- [PATCH v5 3/6] hw/arm/virt: Honor highmem setting when computing the memory map, Marc Zyngier, 2022/01/14
- [PATCH v5 1/6] hw/arm/virt: Add a control for the the highmem PCIe MMIO, Marc Zyngier, 2022/01/14
- [PATCH v5 6/6] hw/arm/virt: Drop superfluous checks against highmem,
Marc Zyngier <=
- [PATCH v5 5/6] hw/arm/virt: Disable highmem devices that don't fit in the PA range, Marc Zyngier, 2022/01/14
- [PATCH v5 2/6] hw/arm/virt: Add a control for the the highmem redistributors, Marc Zyngier, 2022/01/14
- [PATCH v5 4/6] hw/arm/virt: Use the PA range to compute the memory map, Marc Zyngier, 2022/01/14
- Re: [PATCH v5 0/6] target/arm: Reduced-IPA space and highmem fixes, Peter Maydell, 2022/01/18