[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/6] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the
|
From: |
Raphael Norwitz |
|
Subject: |
[PATCH v3 4/6] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd |
|
Date: |
Mon, 17 Jan 2022 04:12:33 +0000 |
From: David Hildenbrand <david@redhat.com>
We end up not closing the file descriptor, resulting in leaking one
file descriptor for each VHOST_USER_REM_MEM_REG message.
Fixes: 875b9fd97b34 ("Support individual region unmap in libvhost-user")
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
---
subprojects/libvhost-user/libvhost-user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index 7dd8e918b4..3f4d7221ca 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -868,6 +868,8 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
vu_panic(dev, "Specified region not found\n");
}
+ close(vmsg->fds[0]);
+
return true;
}
--
2.20.1
- [PATCH v3 0/6] Clean up error handling in libvhost-user memory mapping, Raphael Norwitz, 2022/01/16
- [PATCH v3 1/6] libvhost-user: Add vu_rem_mem_reg input validation, Raphael Norwitz, 2022/01/16
- [PATCH v3 2/6] libvhost-user: Add vu_add_mem_reg input validation, Raphael Norwitz, 2022/01/16
- [PATCH v3 3/6] libvhost-user: Simplify VHOST_USER_REM_MEM_REG, Raphael Norwitz, 2022/01/16
- [PATCH v3 5/6] libvhost-user: prevent over-running max RAM slots, Raphael Norwitz, 2022/01/16
- [PATCH v3 4/6] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd,
Raphael Norwitz <=
- [PATCH v3 6/6] libvhost-user: handle removal of identical regions, Raphael Norwitz, 2022/01/16