Re: [PATCH 4/6] migration: Add ram-only capability

[Nikta Lapshin]

On 1/14/22 14:22, Markus Armbruster wrote:

> Nikita Lapshin <nikita.lapshin@virtuozzo.com> writes:
>
> > If this capability is enabled migration stream
> > will have RAM section only.
> >
> > Signed-off-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
> >       
> [...]
>
> > diff --git a/qapi/migration.json b/qapi/migration.json
> > index d53956852c..626fc59d14 100644
> > --- a/qapi/migration.json
> > +++ b/qapi/migration.json
> > @@ -454,6 +454,8 @@
> >  #
> >  # @no-ram: If enabled, migration stream won't contain any ram in it. (since 7.0)
> >  #
> > +# @ram-only: If enabled, only RAM sections will be sent. (since 7.0)
> > +#
> >       
> What happens when I ask for 'no-ram': true, 'ram-only': true?
>

migrate_caps_check() will return false and print error message that these
capabilities are not compatible.

> >  # Features:
> >  # @unstable: Members @x-colo and @x-ignore-shared are experimental.
> >  #
> > @@ -467,7 +469,7 @@
> >             'block', 'return-path', 'pause-before-switchover', 'multifd',
> >             'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate',
> >             { 'name': 'x-ignore-shared', 'features': [ 'unstable' ] },
> > -           'validate-uuid', 'background-snapshot', 'no-ram'] }
> > +           'validate-uuid', 'background-snapshot', 'no-ram', 'ram-only'] }
> >  ##
> >  # @MigrationCapabilityStatus:
> >  #
> > @@ -521,7 +523,8 @@
> >  #       {"state": true, "capability": "events"},
> >  #       {"state": false, "capability": "postcopy-ram"},
> >  #       {"state": false, "capability": "x-colo"},
> > -#       {"state": false, "capability": "no-ram"}
> > +#       {"state": false, "capability": "no-ram"},
> > +#       {"state": false, "capability": "ram-only"}
> >  #    ]}
> >  #
> >  ##
> >       
>