[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64
From: |
Weiwei Li |
Subject: |
[PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64 |
Date: |
Tue, 18 Jan 2022 09:17:07 +0800 |
From: Guo Ren <ren_guo@c-sky.com>
Highest bits of PTE has been used for svpbmt, ref: [1], [2], so we
need to ignore them. They cannot be a part of ppn.
1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture
4.4 Sv39: Page-Based 39-bit Virtual-Memory System
4.5 Sv48: Page-Based 48-bit Virtual-Memory System
2: https://github.com/riscv/virtual-memory/blob/main/specs/663-Svpbmt-diff.pdf
Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Liu Zhiwei <zhiwei_liu@c-sky.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
target/riscv/cpu_bits.h | 7 +++++++
target/riscv/cpu_helper.c | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
index 5a6d49aa64..282cd8eecd 100644
--- a/target/riscv/cpu_bits.h
+++ b/target/riscv/cpu_bits.h
@@ -490,6 +490,13 @@ typedef enum {
/* Page table PPN shift amount */
#define PTE_PPN_SHIFT 10
+/* Page table PPN mask */
+#if defined(TARGET_RISCV32)
+#define PTE_PPN_MASK 0xffffffffUL
+#elif defined(TARGET_RISCV64)
+#define PTE_PPN_MASK 0x3fffffffffffffULL
+#endif
+
/* Leaf page shift amount */
#define PGSHIFT 12
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 434a83e66a..26608ddf1c 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -619,7 +619,7 @@ restart:
return TRANSLATE_FAIL;
}
- hwaddr ppn = pte >> PTE_PPN_SHIFT;
+ hwaddr ppn = (pte & PTE_PPN_MASK) >> PTE_PPN_SHIFT;
if (!(pte & PTE_V)) {
/* Invalid PTE */
--
2.17.1
- [PATCH v5 0/5] support subsets of virtual memory extension, Weiwei Li, 2022/01/17
- [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64,
Weiwei Li <=
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Anup Patel, 2022/01/17
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Alistair Francis, 2022/01/17
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Guo Ren, 2022/01/18
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Guo Ren, 2022/01/20
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, LIU Zhiwei, 2022/01/20
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Guo Ren, 2022/01/20
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, LIU Zhiwei, 2022/01/20
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Guo Ren, 2022/01/18
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Anup Patel, 2022/01/18
- Re: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Guo Ren, 2022/01/18