[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/2] virtio-mem: Warn if a memory backend with "prealloc=o
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v1 1/2] virtio-mem: Warn if a memory backend with "prealloc=on" is used |
|
Date: |
Tue, 25 Jan 2022 13:08:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 25.01.22 12:19, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (david@redhat.com) wrote:
>> "prealloc=on" for the memory backend does not work as expected, as
>> virtio-mem will simply discard all preallocated memory immediately again.
>> In the best case, it's an expensive NOP. In the worst case, it's an
>> unexpected allocation error.
>>
>> Instead, "prealloc=on" should be specified for the virtio-mem device only,
>> such that virtio-mem will try preallocating memory before plugging
>> memory dynamically to the guest.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Why is this a warning rather than an error that stops creation of the
> device?
No strong opinion, an error might actually be better.
--
Thanks,
David / dhildenb