Re: [PATCH v6 0/7] trace qmp commands

[Stefan Hajnoczi]

On Wed, Jan 26, 2022 at 05:11:23PM +0100, Vladimir Sementsov-Ogievskiy wrote:
> This series aims to add trace points for each qmp command with help of
> qapi code generator.
> 
> v6:
> 01-04,07: add Stefan's r-b
> 01: - subject changed
>     - rename:
>        gen_trace_events --> gen_tracing
>        _gen_trace_events --> _gen_tracing
>        _gent() --> _gen_trace_events()
>     - a bit more compact code for gent initializing
> 03: - rename:
>        gen_trace_events --> gen_tracing
>        _gen_trace_events --> _gen_tracing
> 04: fix --add-trace-events -> --gen-trace in commit message
> 05: - drop extra two sentences
>     - reword
>     - add example .trace-events file
> 06: reword
> 07: rename option to --suppress-tracing
> 
> Vladimir Sementsov-Ogievskiy (7):
>   qapi/gen: Add FOO.trace-events output module
>   qapi/commands: refactor error handling code
>   qapi/commands: Optionally generate trace for QMP commands
>   meson: generate trace events for qmp commands
>   docs/qapi-code-gen: update to cover trace events code generation
>   meson: document, why we don't generate trace events for tests/ and
>     qga/
>   qapi: generate trace events by default
> 
>  docs/devel/qapi-code-gen.rst |  25 ++++++++-
>  meson.build                  |   3 ++
>  qapi/meson.build             |   7 +++
>  qga/meson.build              |  10 +++-
>  scripts/qapi/commands.py     | 101 ++++++++++++++++++++++++++++++-----
>  scripts/qapi/gen.py          |  31 +++++++++--
>  scripts/qapi/main.py         |  14 +++--
>  tests/meson.build            |  10 +++-
>  trace/meson.build            |  11 ++--
>  9 files changed, 185 insertions(+), 27 deletions(-)
> 
> -- 
> 2.31.1
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

signature.asc
Description: PGP signature