Re: [PATCH v4 00/42] CXl 2.0 emulation Support

[Jonathan Cameron]

On Thu, 27 Jan 2022 14:22:52 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:

> Jonathan Cameron <Jonathan.Cameron@huawei.com> writes:
> 
> > Previous version was RFC v3: CXL 2.0 Support.
> > No longer an RFC as I would consider the vast majority of this
> > to be ready for detailed review. There are still questions called
> > out in some patches however.  
> 
> I've been through and added comments through the first half of the
> patches. I'll see if I can get to the second half next week however if
> you beat me to it with a re-rev I expect some ripples from the requested
> changes.
> 
> Aside from ensuring the rest of the builds work:
> 
>   https://gitlab.com/stsquad/qemu/-/pipelines/456700583/failures
>   
> it looks pretty good to me. I await the next version ;-)
> 

Thanks for ploughing through them - it's a great help.
Hopefully I'll get a new version out before you get back to them.

The CI certainly threw up some unexpected issues alongside the
bugs and wrong assumptions and build issues you pointed out.

* can't have a field called ERROR in a register on some archs
* doesn't work if you don't push the tags on the tree... (win builds)

but should be clean in next version.

Thanks,

Jonathan