[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] target/arm: Fix {fp,sve}_exception_el for VHE mode runni
|
From: |
Zenghui Yu |
|
Subject: |
Re: [PATCH 3/4] target/arm: Fix {fp,sve}_exception_el for VHE mode running |
|
Date: |
Sat, 29 Jan 2022 14:50:32 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
Hi Richard,
On 2022/1/27 14:34, Richard Henderson wrote:
+ if (el <= 2) {
+ if (hcr_el2 & HCR_E2H) {
+ /* Check CPTR_EL2.ZEN. */
+ switch (extract32(env->cp15.cptr_el[2], 16, 2)) {
+ case 1:
+ if (el != 0 || !(hcr_el2 & HCR_TGE)) {
It looks to me that the code will be easier to follow if we can
put '!(hcr_el2 & HCR_TGE)' before 'el != 0'.
+ break;
+ }
+ /* fall through */
+ case 0:
+ case 2:
+ return 2;
+ }
Regardless, thanks for the fix.
Reviewed-and-tested-by: Zenghui Yu <yuzenghui@huawei.com>
- Re: [PATCH 1/4] target/arm: Fix sve_zcr_len_for_el for VHE mode running, (continued)