Re: [PATCH v3 3/7] target/riscv: access configuration through cfg_ptr in DisasContext

[Richard Henderson]

On 1/29/22 01:56, Philipp Tomsich wrote:
> The implementation in trans_{rvi,rvv,rvzfh}.c.inc accesses the shallow
> copies (in DisasContext) of some of the elements available in the
> RISCVCPUConfig structure.  This commit redirects accesses to use the
> cfg_ptr copied into DisasContext and removes the shallow copies.
>
> Signed-off-by: Philipp Tomsich<philipp.tomsich@vrull.eu>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
>
> ---
>
> Changes in v3:
> - (new patch) test extension-availability through cfg_ptr in
>    DisasContext, removing the fields that have been copied into
>    DisasContext directly
>
>   target/riscv/insn_trans/trans_rvi.c.inc   |   2 +-
>   target/riscv/insn_trans/trans_rvv.c.inc   | 104 +++++++++++-----------
>   target/riscv/insn_trans/trans_rvzfh.c.inc |   4 +-
>   target/riscv/translate.c                  |  14 ---
>   4 files changed, 55 insertions(+), 69 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~