Re: [PATCH v3 35/40] bsd-user/signal.c: implement do_sigreturn

[Richard Henderson]

On 1/29/22 10:28, Warner Losh wrote:
> +static int reset_signal_mask(target_ucontext_t *ucontext)
> +{
> +    int i;
> +    sigset_t blocked;
> +    target_sigset_t target_set;
> +    TaskState *ts = (TaskState *)thread_cpu->opaque;
> +
> +    for (i = 0; i < TARGET_NSIG_WORDS; i++)
> +        if (__get_user(target_set.__bits[i],
> +                    &ucontext->uc_sigmask.__bits[i])) {
> +            return -TARGET_EFAULT;
> +        }

Nit: missing braces for the loop.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~