[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 02/41] target/ppc: 603: fix restore of GPRs 0-3 on rfi
|
From: |
Peter Maydell |
|
Subject: |
Re: [PULL 02/41] target/ppc: 603: fix restore of GPRs 0-3 on rfi |
|
Date: |
Mon, 31 Jan 2022 17:04:46 +0000 |
On Mon, 31 Jan 2022 at 17:00, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> Here we see checkpatch.pl has no issues with the output of git diff, but when
> you run
> it on the whole file:
> ... it shows up. How is it possible for checkpatch.pl to miss things when
> processing
> diffs instead of whole files?
Probably because checkpatch is a pretty hairy perl script and sometimes
it mis-parses stuff, especially when it's working with a diff hunk
and it has a limited view of the context around the statement.
It's always been best-effort rather than guaranteed to catch all
formatting issues.
For this particular error, it doesn't seem to me worth making Cédric
reroll the pullreq to fix it unless there's some other issue with
it; we can fix it with a followup patch.
thanks
-- PMM
- [PULL 21/41] target/ppc: 405: System call exception cleanup, (continued)
- [PULL 21/41] target/ppc: 405: System call exception cleanup, Cédric Le Goater, 2022/01/31
- [PULL 28/41] target/ppc: Introduce powerpc_excp_books, Cédric Le Goater, 2022/01/31
- [PULL 37/41] target/ppc: 74xx: Program exception cleanup, Cédric Le Goater, 2022/01/31
- [PULL 40/41] target/ppc: 74xx: Set SRRs directly in exception code, Cédric Le Goater, 2022/01/31
- [PULL 09/41] spapr.c: check bus != NULL in spapr_get_fw_dev_path(), Cédric Le Goater, 2022/01/31
- [PULL 24/41] target/ppc: 405: Data Storage exception cleanup, Cédric Le Goater, 2022/01/31
- [PULL 02/41] target/ppc: 603: fix restore of GPRs 0-3 on rfi, Cédric Le Goater, 2022/01/31
- Re: [PULL 02/41] target/ppc: 603: fix restore of GPRs 0-3 on rfi, Cédric Le Goater, 2022/01/31
- Re: [PULL 02/41] target/ppc: 603: fix restore of GPRs 0-3 on rfi, Mark Cave-Ayland, 2022/01/31
[PULL 17/41] target/ppc: Simplify powerpc_excp_40x, Cédric Le Goater, 2022/01/31
[PULL 08/41] target/ppc: fix 'skip KVM' cond in cpu_interrupt_exittb(), Cédric Le Goater, 2022/01/31
[PULL 34/41] target/ppc: Simplify powerpc_excp_74xx, Cédric Le Goater, 2022/01/31
[PULL 31/41] target/ppc: books: External interrupt cleanup, Cédric Le Goater, 2022/01/31
[PULL 22/41] target/ppc: 405: Alignment exception cleanup, Cédric Le Goater, 2022/01/31
[PULL 20/41] target/ppc: 405: External exception cleanup, Cédric Le Goater, 2022/01/31
[PULL 13/41] ppc/ppc405: Fix TLB flushing, Cédric Le Goater, 2022/01/31