Re: [PATCH 2/2] tests: Update CentOS 8 container to CentOS Stream 8

[Daniel P . Berrangé]

On Tue, Feb 01, 2022 at 09:08:22AM -0800, Andrea Bolognani wrote:
> On Tue, Feb 01, 2022 at 11:19:11AM +0100, Thomas Huth wrote:
> > +++ b/tests/docker/dockerfiles/centos8.docker
> > @@ -1,10 +1,10 @@
> >  # THIS FILE WAS AUTO-GENERATED
> >  #
> > -#  $ lcitool dockerfile centos-8 qemu
> > +#  $ lcitool dockerfile centos-stream-8 qemu
> >  #
> >  # https://gitlab.com/libvirt/libvirt-ci
> >
> > -FROM docker.io/library/centos:8
> > +FROM quay.io/centos/centos:stream8
> [...]
> > +++ b/tests/lcitool/refresh
> > @@ -77,7 +77,7 @@ ubuntu2004_tsanhack = [
> >  ]
> >
> >  try:
> > -   generate_dockerfile("centos8", "centos-8")
> > +   generate_dockerfile("centos8", "centos-stream-8")
> 
> I'm not convinced this is a good idea.
> 
> CentOS 8 and CentOS Stream 8 are two pretty distinct operating
> systems in terms of update cadence and stability expectations, so I
> think that using the label "centos8" for containers and CI jobs that
> are actually consuming CentOS Stream 8 is going to be a source of
> confusion.

Given the EOL of what I call the "traditional" CentOS model at the
end of 2021, both "CentOS" and "CentOS Stream" terms effectively
mean the same thing now.

If we were trying to support CI for both traditional CentOS and
CentOS Stream at the same time, then using the distinct naming
is sensible.  libvirt-ci.git is in this situation

Since QEMU should only care about CentOS Stream from this point
forwards, then I don't think we neccesarily[1] need to make the
naming more verbose by adding the word 'stream' everywhere.

The caveat is that aside from this dockerfile, we also have a
VM config in test/vm/ that historically used traditional CentOS.
That may also need updating to point to Stream unless it has
seemlessly transitioned to using Stream content without us
needing to change anything. I've not looked closely at that yet.

Regards,
Daniel

[1] what would make me change my mind is if we renamed all the
    QEMU dockerfiles so use the same distro naming convention
    as libvirt-ci.git rather than having QEMU's own naming. I've
    thought about suggesting it but it wasn't a high priority
    since lcitool usage is in its infancy in QEMU still
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|