qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/3] qmp: Support for querying stats


From: Mark Kanda
Subject: Re: [PATCH v3 1/3] qmp: Support for querying stats
Date: Thu, 3 Feb 2022 12:12:57 -0600
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1

Thanks Daniel,

On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
+#
+# Since: 7.0
+##
+{ 'enum' : 'StatType',
+  'data' : [ 'cumulative', 'instant', 'peak',
+             'linear-hist', 'log-hist', 'unknown' ] }
IMHO 'unknown' shouldn't exist at all.


I added the 'unknown' member here (and in other enums) to handle situations where QEMU is behind KVM in terms of enumerating the various stat types, units, etc. I feel this will be a semi-common scenario (old QEMU on a new kernel) and with 'unknown', QEMU can at least display the raw data.

That said, I happy skip 'unknown' entries if you think that's better.

Thanks/regards,
-Mark


reply via email to

[Prev in Thread] Current Thread [Next in Thread]