qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/10] hw/remote: Add missing include


From: Richard Henderson
Subject: Re: [PATCH 02/10] hw/remote: Add missing include
Date: Sun, 6 Feb 2022 10:48:39 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/4/22 06:37, Philippe Mathieu-Daudé wrote:
Currently "qemu/error-report.h" is implicitly included, however
if headers in include/ get refactored, we get:

   hw/remote/proxy-memory-listener.c: In function 
‘proxy_memory_listener_commit’:
   hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of 
function ‘error_report’; did you mean ‘error_report_err’? 
[-Werror=implicit-function-declaration]
     183 |         error_report("Number of fds is more than %d", 
REMOTE_MAX_FDS);
         |         ^~~~~~~~~~~~
         |         error_report_err

Add the missing "qemu/error-report.h" header to avoid that.

Reviewed-by: Jagannathan Raman<jag.raman@oracle.com>
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  hw/remote/proxy-memory-listener.c | 1 +
  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]