[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 11/24] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing th
|
From: |
Michael S. Tsirkin |
|
Subject: |
[PULL v2 11/24] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd |
|
Date: |
Sun, 6 Feb 2022 04:38:14 -0500 |
From: David Hildenbrand <david@redhat.com>
We end up not closing the file descriptor, resulting in leaking one
file descriptor for each VHOST_USER_REM_MEM_REG message.
Fixes: 875b9fd97b34 ("Support individual region unmap in libvhost-user")
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Message-Id: <20220117041050.19718-5-raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index 7dd8e918b4..3f4d7221ca 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -868,6 +868,8 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
vu_panic(dev, "Specified region not found\n");
}
+ close(vmsg->fds[0]);
+
return true;
}
--
MST
- [PULL v2 15/24] ACPI ERST: bios-tables-test.c steps 1 and 2, (continued)
- [PULL v2 15/24] ACPI ERST: bios-tables-test.c steps 1 and 2, Michael S. Tsirkin, 2022/02/06
- [PULL v2 16/24] ACPI ERST: PCI device_id for ERST, Michael S. Tsirkin, 2022/02/06
- [PULL v2 17/24] ACPI ERST: header file for ERST, Michael S. Tsirkin, 2022/02/06
- [PULL v2 19/24] ACPI ERST: build the ACPI ERST table, Michael S. Tsirkin, 2022/02/06
- [PULL v2 18/24] ACPI ERST: support for ACPI ERST feature, Michael S. Tsirkin, 2022/02/06
- [PULL v2 20/24] ACPI ERST: create ACPI ERST table for pc/x86 machines, Michael S. Tsirkin, 2022/02/06
- [PULL v2 21/24] ACPI ERST: qtest for ERST, Michael S. Tsirkin, 2022/02/06
- [PULL v2 22/24] ACPI ERST: bios-tables-test testcase, Michael S. Tsirkin, 2022/02/06
- [PULL v2 24/24] util/oslib-posix: Fix missing unlock in the error path of os_mem_prealloc(), Michael S. Tsirkin, 2022/02/06
- [PULL v2 23/24] ACPI ERST: step 6 of bios-tables-test.c, Michael S. Tsirkin, 2022/02/06
- [PULL v2 11/24] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd,
Michael S. Tsirkin <=
- Re: [PULL v2 00/24] virtio,pc: features, cleanups, fixes, Peter Maydell, 2022/02/06