qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 01/11] 9p: linux: Fix a couple Linux assumptions


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 01/11] 9p: linux: Fix a couple Linux assumptions
Date: Sun, 6 Feb 2022 22:15:43 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1

On 6/2/22 21:07, Will Cohen wrote:
From: Keno Fischer <keno@juliacomputing.com>

  - Guard Linux only headers.
  - Add qemu/statfs.h header to abstract over the which
    headers are needed for struct statfs
  - Define `ENOATTR` only if not only defined
    (it's defined in system headers on Darwin).

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>

While it might at first appear that fsdev/virtfs-proxy-header.c would
need similar adjustment for darwin as file-op-9p here, a later patch in
this series disables virtfs-proxy-helper for non-Linux. Allowing
virtfs-proxy-helper on darwin could potentially be an additional
optimization later.

[Will Cohen: - Fix headers for Alpine
              - Integrate statfs.h back into file-op-9p.h
              - Remove superfluous header guards from file-opt-9p
              - Add note about virtfs-proxy-helper being disabled
                on non-Linux for this patch series]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
---
  fsdev/file-op-9p.h   | 9 ++++++++-
  hw/9pfs/9p-local.c   | 2 ++
  hw/9pfs/9p.c         | 4 ++++
  include/qemu/xattr.h | 4 +++-
  4 files changed, 17 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]