qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/13] exec: Move translation declarations to 'translate-all.


From: Richard Henderson
Subject: Re: [PATCH 13/13] exec: Move translation declarations to 'translate-all.h'
Date: Wed, 9 Feb 2022 10:00:11 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/9/22 02:22, Philippe Mathieu-Daudé wrote:
Translation declarations are only useful to TCG accelerator.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Ug.

So, like, what's you vision of exec-all.h vs translate-all.h? Certainly there's not much in translate-all.h at the moment. Taking a case at random, what has gdbstub.c got to do with "translation" as opposed to "execution"?

I would expect some documetation updates to the top of these headers. I don't see why everything has to move all at once, especially since translate-all.h already includes exec-all.h.

I can see that exec-all.h is currently a garbage bag, but I strongly suspect that you're moving too much here.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]