Re: [PATCH v2 06/12] Hexagon (tests/tcg/hexagon) test instructions that might set bits in USR

[Richard Henderson]

On 2/10/22 13:15, Taylor Simpson wrote:
> +#define CLEAR_USRBITS \
> +    "r2 = usr\n\t" \
> +    "r2 = clrbit(r2, #0)\n\t" \
> +    "r2 = clrbit(r2, #1)\n\t" \
> +    "r2 = clrbit(r2, #2)\n\t" \
> +    "r2 = clrbit(r2, #3)\n\t" \
> +    "r2 = clrbit(r2, #4)\n\t" \
> +    "r2 = clrbit(r2, #5)\n\t" \
> +    "usr = r2\n\t"

It's just a test case, so it doesn't really matter, but

    r2 = and(r2, #~0x3f)

surely?

Otherwise,
Acked-by: Richard Henderson <richard.henderson@linaro.org>


r~