Re: [PATCH v2 7/7] aspeed/sdmc: Add trace events

[Philippe Mathieu-Daudé]

On 18/2/22 09:18, Cédric Le Goater wrote:
> This is useful to analyze changes in the U-Boot RAM driver when SDRAM
> training is performed.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/misc/aspeed_sdmc.c | 2 ++
>   hw/misc/trace-events  | 4 ++++
>   2 files changed, 6 insertions(+)
>
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index 08f856cbda7e..d2a3931033b3 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -130,6 +130,7 @@ static uint64_t aspeed_sdmc_read(void *opaque, hwaddr addr, 
> unsigned size)
>           return 0;
>       }

> +# aspeed_sdmc.c
> +aspeed_sdmc_write(uint32_t reg, uint32_t data) "reg @0x%" PRIx32 " data: 0x%" 
> PRIx32
> +aspeed_sdmc_read(uint32_t reg, uint32_t data) "reg @0x%" PRIx32 " data: 0x%" 
> PRIx32

I'm surprised by the uint32_t conversion, but why not.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>