Re: [PATCH] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

[Daniel P . Berrangé]

On Mon, Feb 21, 2022 at 04:08:50PM +0000, Dov Murik wrote:
> Add a new field 'cpu0-id' to the response of query-sev-capabilities
> QMP command.  The value of the field is the hex-encoded 64-byte unique
> ID of the CPU0 (socket 0), which can be used to retrieve the signed CEK
> of the CPU from AMD's Key Distribution Service (KDS).
> 
> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> ---
>  qapi/misc-target.json |  4 ++++
>  target/i386/sev.c     | 43 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+)
> 
> diff --git a/qapi/misc-target.json b/qapi/misc-target.json
> index 4bc45d2474..d9b4991c86 100644
> --- a/qapi/misc-target.json
> +++ b/qapi/misc-target.json
> @@ -177,6 +177,8 @@
>  #
>  # @cert-chain:  PDH certificate chain (base64 encoded)
>  #
> +# @cpu0-id: 64-byte unique ID of CPU0 (hex encoded) (since 7.0)

For binary data in QAPI we've pretty much standardized on using
base64 encoding. I think we should stick with that encoding.

> +#
>  # @cbitpos: C-bit location in page table entry
>  #
>  # @reduced-phys-bits: Number of physical Address bit reduction when SEV is
> @@ -187,6 +189,7 @@
>  { 'struct': 'SevCapability',
>    'data': { 'pdh': 'str',
>              'cert-chain': 'str',
> +            'cpu0-id': 'str',
>              'cbitpos': 'int',
>              'reduced-phys-bits': 'int'},
>    'if': 'TARGET_I386' }
> @@ -205,6 +208,7 @@
>  #
>  # -> { "execute": "query-sev-capabilities" }
>  # <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE",
> +#                  "cpu0-id": "5ea2e1...90ea39",
>  #                  "cbitpos": 47, "reduced-phys-bits": 5}}
>  #
>  ##

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|