Re: [PATCH 1/2] ui/cocoa.m: Fix updateUIInfo threading issues

[Peter Maydell]

On Tue, 22 Feb 2022 at 17:13, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> On Wed, Feb 23, 2022 at 2:06 AM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
> > diff --git a/ui/cocoa.m b/ui/cocoa.m
> > index a8f1cdaf926..f8d3d8ad7a6 100644
> > --- a/ui/cocoa.m
> > +++ b/ui/cocoa.m
> > @@ -522,8 +522,9 @@ QemuCocoaView *cocoaView;
> >      }
> >  }
> >
> > -- (void) updateUIInfo
> > +- (void) doUpdateUIInfo
>
> You may add the suffix "Locked" to align with handleEventLocked and
> make the intention more explicit.

Ah, good idea.

> > +    /* Now we're set up, tell the UI layer our initial window size */
> > +    dispatch_async(dispatch_get_main_queue(), ^{
> > +        [cocoaView updateUIInfo];
> > +    });
> >  }
>
> This is not necessary since register_displaychangelistener calls 
> dpy_gfx_switch.

Cool, I'll drop this bit.

-- PMM