qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 09/11] 9p: darwin: Implement compatibility for mknodat


From: Christian Schoenebeck
Subject: Re: [PATCH v8 09/11] 9p: darwin: Implement compatibility for mknodat
Date: Fri, 25 Feb 2022 17:44:51 +0100

On Freitag, 25. Februar 2022 17:38:51 CET Will Cohen wrote:
> On Fri, Feb 25, 2022 at 11:31 AM Christian Schoenebeck <
> 
> qemu_oss@crudebyte.com> wrote:
> > On Freitag, 25. Februar 2022 15:00:40 CET Will Cohen wrote:
> > > On Tue, Feb 22, 2022 at 9:27 AM Christian Schoenebeck
[...]
> > > osdep.h is the wrong place, should it go back to 9p-util, where it lived
> > > before it moved to osdep?
> > 
> > The other function Peter wanted out from osdep.h would fall into that
> > category
> > as well. I understand it like "only put things into osdep.h as very last
> > resort". CCing Peter on this. If he doesn't give you green light, or on
> > doubt,
> > then yes please move it from osdep -> 9p-util.
> > 
> > Will, are you planning to send a v9 of this series soon? Next week I need
> > to
> > add changes that would collide with these here. So if you intend to send
> > it
> > soon, then I just wait so that we can finally queue these macOS patches
> > here
> > for QEMU 7.0, before I would go along with my changes.
> > 
> > Best regards,
> > Christian Schoenebeck
> 
> Prepping a v9 now based on all the other changes + the formatting issues.
> I'll send this weekend if that's okay!

Thumbs up! :)

Best regards,
Christian Schoenebeck





reply via email to

[Prev in Thread] Current Thread [Next in Thread]