qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/7] target/nios2: Rewrite interrupt handling


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 7/7] target/nios2: Rewrite interrupt handling
Date: Sun, 27 Feb 2022 23:05:18 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

On 27/2/22 19:21, Richard Henderson wrote:
Drop irq_pending boolean.
Drop helper_check_interrupts.
Move checks for irq disabled into nios2_cpu_exec_interrupt.
End the TB on writes to ienable, just like to status.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/nios2/cpu.h       |  1 -
  target/nios2/helper.h    |  1 -
  target/nios2/cpu.c       | 10 ++++------
  target/nios2/op_helper.c | 19 -------------------
  target/nios2/translate.c | 14 +++++---------
  5 files changed, 9 insertions(+), 36 deletions(-)

LGTM but better have another review...

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]