[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/9] qapi/migration: Fix examples document wrong field name for ar
|
From: |
Markus Armbruster |
|
Subject: |
[PULL 4/9] qapi/migration: Fix examples document wrong field name for arguments |
|
Date: |
Mon, 28 Feb 2022 12:26:08 +0100 |
From: Fabian Holler <fabian.holler@simplesurance.de>
The examples for the snapshot-* and calc-dirty-rate commands document
that arguments for the commands are passed in a 'data' field.
This is wrong, passing them in a "data" field results in
the error:
{"error": {"class": "GenericError", "desc": "QMP input member 'data'
is unexpected"}}
Arguments are expected to be passed in an field called "arguments".
Replace "data" with "arguments" in the snapshot-* and calc-dirty-rate
command examples.
Signed-off-by: Fabian Holler <fabian.holler@simplesurance.de>
Message-Id: <20220222170116.63105-1-fabian.holler@simplesurance.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/migration.json | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 5975a0e104..18e2610e88 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1843,8 +1843,8 @@
# Since: 5.2
#
# Example:
-# {"command": "calc-dirty-rate", "data": {"calc-time": 1,
-# 'sample-pages': 512} }
+# {"command": "calc-dirty-rate", "arguments": {"calc-time": 1,
+# 'sample-pages': 512} }
#
##
{ 'command': 'calc-dirty-rate', 'data': {'calc-time': 'int64',
@@ -1888,7 +1888,7 @@
# Example:
#
# -> { "execute": "snapshot-save",
-# "data": {
+# "arguments": {
# "job-id": "snapsave0",
# "tag": "my-snap",
# "vmstate": "disk0",
@@ -1949,7 +1949,7 @@
# Example:
#
# -> { "execute": "snapshot-load",
-# "data": {
+# "arguments": {
# "job-id": "snapload0",
# "tag": "my-snap",
# "vmstate": "disk0",
@@ -2002,7 +2002,7 @@
# Example:
#
# -> { "execute": "snapshot-delete",
-# "data": {
+# "arguments": {
# "job-id": "snapdelete0",
# "tag": "my-snap",
# "devices": ["disk0", "disk1"]
--
2.35.1
- [PULL 0/9] QAPI patches patches for 2022-02-28, Markus Armbruster, 2022/02/28
- [PULL 7/9] hw/rtc: Compile pl031 once-only, Markus Armbruster, 2022/02/28
- [PULL 6/9] qapi: Document some missing details of RTC_CHANGE event, Markus Armbruster, 2022/02/28
- [PULL 3/9] qapi: Fix stale reference to scripts/qapi.py in a comment, Markus Armbruster, 2022/02/28
- [PULL 4/9] qapi/migration: Fix examples document wrong field name for arguments,
Markus Armbruster <=
- [PULL 5/9] qapi: Move RTC_CHANGE back out of target schema, Markus Armbruster, 2022/02/28
- [PULL 8/9] rtc: Have event RTC_CHANGE identify the RTC by QOM path, Markus Armbruster, 2022/02/28
- [PULL 2/9] keyval: Fix grammar comment to cover downstream prefix, Markus Armbruster, 2022/02/28
- [PULL 9/9] qapi: Belatedly adjust limitations documentation, Markus Armbruster, 2022/02/28
- [PULL 1/9] scripts/qapi: minor delinting, Markus Armbruster, 2022/02/28