Re: [PATCH v6 11/19] vfio-user: handle PCI config space accesses

[Jag Raman]

> On Feb 22, 2022, at 6:09 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> On Thu, Feb 17, 2022 at 02:48:58AM -0500, Jagannathan Raman wrote:
>> Define and register handlers for PCI config space accesses
>> 
>> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
>> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> hw/remote/vfio-user-obj.c | 45 +++++++++++++++++++++++++++++++++++++++
>> hw/remote/trace-events    |  2 ++
>> 2 files changed, 47 insertions(+)
> 
> hw/pci/pci.c:pci_update_mappings() will unmap/map BARs when the
> vfio-user client touches BARs. Please add a comment that the remote
> machine type never dispatches memory accesses in the global memory address
> space and therefore we don't care that multiple remote devices may set
> up conflicting Memory and I/O Space BARs.

OK, will do.

Thank you!
--
Jag