Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

[Jag Raman]

> On Feb 28, 2022, at 1:12 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> On 2/25/22 05:03, Jag Raman wrote:
>>> On Feb 24, 2022, at 12:52 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> 
>>> On 2/22/22 20:05, Jag Raman wrote:
>>>>> -            defaults[prefix + 'COMPILER'] = exe_list
>>>>> +            defaults[f'{prefix}COMPILER'] = [exe_list[0]]
>>>>> +            for i in range(1, len(exe_list)):
>>>>> +                defaults[f'{prefix}COMPILER_ARG{i}'] = [exe_list[i]]
>>>>> +
>>>>>             if comp_obj.get_id() == 'clang-cl':
>>>>>                 defaults['CMAKE_LINKER'] = comp_obj.get_linker_exelist()
>>>> This fix works at my end.
>>> 
>>> Would you please check that -m64 and -mcx16 are passed indeed to the 
>>> compiler?
>> Hi Paolo,
>> Yes, I’m able to see that -m64 and -mcx16 are passed to the compiler.
>> # cat ./subprojects/libvfio-user/__CMake_build/CMakeMesonToolchainFile.cmake
>> …
>> set(CMAKE_C_COMPILER "/opt/rh/devtoolset-9/root/usr/bin/cc")
>> set(CMAKE_C_COMPILER_ARG1 "-m64")
>> set(CMAKE_C_COMPILER_ARG2 "-mcx16")
>> …
> 
> I reproduced this with CMake 3.17.x and it's fixed by 3.19.x.  I'll send the 
> fix to Meson, but for now I recommend requiring a newer CMake and just 
> dropping this patch.

OK, got it.

Thank you!
--
Jag

> 
> Paolo