Re: [PATCH v6 1/4] tests/acpi: i386: allow FACP acpi table changes

[Ani Sinha]

On Sun, Mar 6, 2022 at 4:49 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Fri, Mar 04, 2022 at 08:37:19PM +0530, Ani Sinha wrote:
> > From: Liav Albani <liavalb@gmail.com>
> >
> > The FACP table is going to be changed for x86/q35 machines. To be sure
> > the following changes are not breaking any QEMU test this change follows
> > step 2 from the bios-tables-test.c guide on changes that affect ACPI
> > tables.
> >
> > Signed-off-by: Liav Albani <liavalb@gmail.com>
> > Acked-by: Ani Sinha <ani@anisinha.ca>
> > ---
> >  tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h 
> > b/tests/qtest/bios-tables-test-allowed-diff.h
> > index dfb8523c8b..7570e39369 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1 +1,5 @@
> >  /* List of comma-separated changed AML files to ignore */
> > +"tests/data/acpi/q35/FACP",
> > +"tests/data/acpi/q35/FACP.nosmm",
> > +"tests/data/acpi/q35/FACP.slic",
> > +"tests/data/acpi/q35/FACP.xapic",
>
> For me make check fails with the changes in patch 2.
> what about the rest of q35 FACP tables?

This is what I have :

anisinha@anisinha-lenovo:~/workspace/qemu/tests/data/acpi/q35$ ls -l FACP*
-rw-rw-r-- 1 anisinha anisinha 244 Mar  4 21:07 FACP
-rw-rw-r-- 1 anisinha anisinha 244 Mar  4 21:07 FACP.nosmm
-rw-rw-r-- 1 anisinha anisinha 244 Mar  4 21:07 FACP.slic
-rw-rw-r-- 1 anisinha anisinha 244 Mar  4 21:07 FACP.xapic

Do you have some more tables? Strange!