Re: [PULL 00/33] Abstract ArchCPU

[Philippe Mathieu-Daudé]

+Daniel/Alex

On 6/3/22 20:56, Peter Maydell wrote:
> On Sun, 6 Mar 2022 at 19:06, Philippe Mathieu-Daudé
> <philippe.mathieu.daude@gmail.com> wrote:
> > I see. I only have access to aarch64 Darwin, not x86_64; I was relying
> > on our CI for that (my GitLab CI is green). I'll work a fix, thanks.
>
> This was on my ad-hoc stuff -- I guess our gitlab CI for macos
> doesn't build hvf ?

No, it does:

https://gitlab.com/philmd/qemu/-/jobs/2167582776#L6444

  Targets and accelerators
    KVM support                  : NO
    HAX support                  : YES
    HVF support                  : YES
    WHPX support                 : NO
    NVMM support                 : NO
    Xen support                  : NO
    TCG support                  : YES

But the Cirrus job are allowed to fail:

  .cirrus_build_job:
    stage: build
    image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
    needs: []
    allow_failure: true

So I've been missing this error since 2 months...

  In file included from ../target/i386/hvf/x86_task.c:22:
  ../target/i386/hvf/x86_emu.h:27:30: error: declaration of 'struct 
CPUX86State' will not be visible outside of this function 
[-Werror,-Wvisibility]
  bool exec_instruction(struct CPUX86State *env, struct x86_decode *ins);
                               ^