qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/13] hw/mips/gt64xxx_pci: Resolve gt64120_register()


From: Richard Henderson
Subject: Re: [PATCH 07/13] hw/mips/gt64xxx_pci: Resolve gt64120_register()
Date: Tue, 8 Mar 2022 08:32:14 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 3/7/22 03:43, Philippe Mathieu-Daudé wrote:
From: Bernhard Beschow<shentey@gmail.com>

Now that gt64120_register() lost its pic parameter, there is an
opportunity to remove it. gt64120_register() is old style by wrapping
qdev API, and the new style is to use qdev directly. So take the
opportunity and modernize the code.

Suggested-by: BALATON Zoltan<balaton@eik.bme.hu>
Signed-off-by: Bernhard Beschow<shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
Reviewed-by: BALATON Zoltan<balaton@eik.bme.hu>
Message-Id:<20220217101924.15347-8-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  hw/mips/gt64xxx_pci.c  | 21 ++++-----------------
  hw/mips/malta.c        |  3 ++-
  include/hw/mips/mips.h |  3 ---
  3 files changed, 6 insertions(+), 21 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]