Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().

[John Snow]

On Tue, Mar 22, 2022 at 1:00 PM Hanna Reitz <hreitz@redhat.com> wrote:
>
> On 18.03.22 21:36, John Snow wrote:
> > Like qemu-img, qemu-io returning 0 should be the norm and not the
> > exception. Remove all calls to qemu_io_silent that just assert the
> > return code is zero (That's every last call, as it turns out), and
> > replace them with a normal qemu_io() call.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   tests/qemu-iotests/216                        | 12 +++++-----
> >   tests/qemu-iotests/218                        |  5 ++---
> >   tests/qemu-iotests/224                        |  4 ++--
> >   tests/qemu-iotests/258                        | 12 +++++-----
> >   tests/qemu-iotests/298                        | 16 ++++++--------
> >   tests/qemu-iotests/310                        | 22 +++++++++----------
> >   tests/qemu-iotests/iotests.py                 | 16 --------------
> >   tests/qemu-iotests/tests/image-fleecing       |  4 ++--
> >   .../tests/mirror-ready-cancel-error           |  2 +-
> >   .../qemu-iotests/tests/stream-error-on-reset  |  4 ++--
> >   10 files changed, 39 insertions(+), 58 deletions(-)
>
> qemu_io_silent_check() was unused anyway, right...?
>
> Reviewed-by: Hanna Reitz <hreitz@redhat.com>
>

As far as I can tell.