[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/15] iotests: remove qemu_io_pipe_and_status()
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 13/15] iotests: remove qemu_io_pipe_and_status() |
|
Date: |
Tue, 22 Mar 2022 15:28:48 -0400 |
On Tue, Mar 22, 2022 at 12:39 PM Hanna Reitz <hreitz@redhat.com> wrote:
>
> On 18.03.22 21:36, John Snow wrote:
> > I know we just added it, sorry. This is done in favor of qemu_io() which
> > *also* returns the console output and status, but with more robust error
> > handling on failure.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > tests/qemu-iotests/iotests.py | 3 ---
> > tests/qemu-iotests/tests/image-fleecing | 12 +++---------
> > 2 files changed, 3 insertions(+), 12 deletions(-)
>
> Reviewed-by: Hanna Reitz <hreitz@redhat.com>
I goofed this patch -- some of the failures in this test are expected
and this patch breaks the test. Dropping the R-Bs. v2 will explain
what's up in the commit message.
--js
- Re: [PATCH 05/15] iotests: create generic qemu_tool() function, (continued)
- [PATCH 06/15] iotests: rebase qemu_io() on top of qemu_tool(), John Snow, 2022/03/18
- [PATCH 13/15] iotests: remove qemu_io_pipe_and_status(), John Snow, 2022/03/18
- [PATCH 08/15] iotests/149: fixup, John Snow, 2022/03/18
- [PATCH 11/15] iotests/migration-permissions: fixup, John Snow, 2022/03/18
- [PATCH 07/15] iotests/030: fixup, John Snow, 2022/03/18
- [PATCH 09/15] iotests/205: fixup, John Snow, 2022/03/18
- [PATCH 10/15] iotests/245: fixup, John Snow, 2022/03/18