Re: [PATCH 2/3] linux-user/arm: Implement __kernel_cmpxchg with host atomics

[Richard Henderson]

On 3/22/22 13:08, Laurent Vivier wrote:
> I have removed this patch and the following one from the branch because it hangs when 
> executed in an armhf/bionic chroot the following example:
>
> cat > /tmp/hello.go <<EOF
> package main
>
> import "fmt"
>
> func main() {
>          fmt.Println("Hello Google!")
> }
> EOF
>
> go run /tmp/hello.go

I don't see a hang.  I see a SIGBUS, due to a silly typo here:


> +static void arm_kernel_cmpxchg32_helper(CPUARMState *env)
> +{
> +    uint32_t oldval, newval, val, addr, cpsr, *host_addr;
> +
> +    oldval = env->regs[0];
> +    newval = env->regs[1];
> +    addr = env->regs[2];
> +
> +    mmap_lock();
> +    host_addr = atomic_mmu_lookup(env, addr, 8); 

s/8/4/.


r~