[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 13/32] error-report: replace deprecated g_get_current_time() with
|
From: |
marcandre . lureau |
|
Subject: |
[PATCH 13/32] error-report: replace deprecated g_get_current_time() with glib >= 2.62 |
|
Date: |
Wed, 23 Mar 2022 19:57:24 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
According to GLib API:
g_get_current_time has been deprecated since version 2.62 and should not
be used in newly-written code. GTimeVal is not year-2038-safe. Use
g_get_real_time() instead.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
include/glib-compat.h | 10 ++++++++++
util/qemu-error.c | 17 ++++++++++++++---
2 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/include/glib-compat.h b/include/glib-compat.h
index 3113a7d2af84..dc14d3ec0d1e 100644
--- a/include/glib-compat.h
+++ b/include/glib-compat.h
@@ -145,6 +145,16 @@ qemu_g_test_slow(void)
#define g_test_thorough() qemu_g_test_slow()
#define g_test_quick() (!qemu_g_test_slow())
+#if GLIB_CHECK_VERSION(2,62,0)
+static inline gchar *
+g_date_time_format_iso8601_compat(GDateTime *datetime)
+{
+ return g_date_time_format_iso8601(datetime);
+}
+
+#define g_date_time_format_iso8601 g_date_time_format_iso8601_compat
+#endif
+
#pragma GCC diagnostic pop
#endif
diff --git a/util/qemu-error.c b/util/qemu-error.c
index 7769aee8e791..4ea380dd4169 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -180,6 +180,19 @@ static void print_loc(void)
}
}
+static char *
+real_time_iso8601(void)
+{
+#if GLIB_CHECK_VERSION(2,62,0)
+ g_autoptr(GDateTime) dt = g_date_time_new_from_unix_utc(g_get_real_time());
+ return g_date_time_format_iso8601(dt);
+#else
+ GTimeVal tv;
+ g_get_current_time(&tv);
+ return g_time_val_to_iso8601(&tv);
+#endif
+}
+
/*
* Print a message to current monitor if we have one, else to stderr.
* @report_type is the type of message: error, warning or informational.
@@ -189,12 +202,10 @@ static void print_loc(void)
*/
static void vreport(report_type type, const char *fmt, va_list ap)
{
- GTimeVal tv;
gchar *timestr;
if (message_with_timestamp && !monitor_cur()) {
- g_get_current_time(&tv);
- timestr = g_time_val_to_iso8601(&tv);
+ timestr = real_time_iso8601();
error_printf("%s ", timestr);
g_free(timestr);
}
--
2.35.1.273.ge6ebfd0e8cbb
- [PATCH 07/32] Replace TARGET_WORDS_BIGENDIAN, (continued)
- [PATCH 07/32] Replace TARGET_WORDS_BIGENDIAN, marcandre . lureau, 2022/03/23
- [PATCH 09/32] include/qapi: add g_autoptr support for qobject types, marcandre . lureau, 2022/03/23
- [PATCH 10/32] tests: replace free_all() usage with g_auto, marcandre . lureau, 2022/03/23
- [PATCH 12/32] qga: replace deprecated g_get_current_time(), marcandre . lureau, 2022/03/23
- [PATCH 11/32] Replace qemu_real_host_page variables with inlined functions, marcandre . lureau, 2022/03/23
- [PATCH 14/32] util: rename qemu-error.c to match its header name, marcandre . lureau, 2022/03/23
- [PATCH 13/32] error-report: replace deprecated g_get_current_time() with glib >= 2.62,
marcandre . lureau <=
- [PATCH 15/32] error-report: use error_printf() for program prefix, marcandre . lureau, 2022/03/23
- [PATCH 16/32] include: move TFR to osdep.h, marcandre . lureau, 2022/03/23
- [PATCH 18/32] include: move qemu_pipe() to osdep.h, marcandre . lureau, 2022/03/23
- [PATCH 17/32] include: move qemu_write_full() declaration to osdep.h, marcandre . lureau, 2022/03/23
- [PATCH 19/32] include: move coroutine IO functions to coroutine.h, marcandre . lureau, 2022/03/23
- [PATCH 20/32] include: move dump_in_progress() to runstate.h, marcandre . lureau, 2022/03/23
- [PATCH 21/32] include: move C/util-related declarations to cutils.h, marcandre . lureau, 2022/03/23
- [PATCH 22/32] include: move cpu_exec* declarations to cpu-common.h, marcandre . lureau, 2022/03/23
- [PATCH 23/32] include: move target page bits declaration to page-vary.h, marcandre . lureau, 2022/03/23