Re: [PATCH v4 05/13] accel/tcg: Init TCG cflags in vCPU thread handler

[Richard Henderson]

On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé<f4bug@amsat.org>
>
> Move TCG cflags initialization to thread handler.
> Remove the duplicated assert checks.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   accel/tcg/tcg-accel-ops-mttcg.c | 5 ++---
>   accel/tcg/tcg-accel-ops-rr.c    | 7 +++----
>   2 files changed, 5 insertions(+), 7 deletions(-)

Why move into the thread handler?  Seems fine where it is.
I agree with the removal of duplicate asserts, but I'd have
removed them the other way around...


r~