[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event |
|
Date: |
Thu, 24 Mar 2022 16:57:00 -0400 |
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote:
>
> * qom-path is not optional
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/machine.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 42fc68403d..9c460ec450 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1356,7 +1356,8 @@
> # Example:
> #
> # <- { "event": "MEMORY_DEVICE_SIZE_CHANGE",
> -# "data": { "id": "vm0", "size": 1073741824},
> +# "data": { "id": "vm0", "size": 1073741824,
> +# "qom-path": "/machine/unattached/device[2]" },
> # "timestamp": { "seconds": 1588168529, "microseconds": 201316 } }
> #
> ##
> --
> 2.35.1
>
I'll just assume this is a realistic qom-path and not actually try to check 😅
Reviewed-by: John Snow <jsnow@redhat.com>
- [PATCH 03/14] qapi: fix example of BLOCK_IO_ERROR event, (continued)
- [PATCH 03/14] qapi: fix example of BLOCK_IO_ERROR event, Victor Toso, 2022/03/24
- [PATCH 07/14] qapi: fix example of UNPLUG_PRIMARY event, Victor Toso, 2022/03/24
- [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/24
- [PATCH 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/24
- [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/24
- Re: [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event,
John Snow <=
- [PATCH 10/14] qapi: run-state examples: add missing timestamp, Victor Toso, 2022/03/24
- [PATCH 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/24
- [PATCH 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/24