[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/14] qapi: run-state examples: add missing timestamp
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 10/14] qapi: run-state examples: add missing timestamp |
|
Date: |
Thu, 24 Mar 2022 17:16:09 -0400 |
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote:
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/run-state.json | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 1b9f64c9cd..f87b9378ac 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -426,7 +426,8 @@
> # Example:
> #
> # <- { "event": "GUEST_PANICKED",
> -# "data": { "action": "pause" } }
> +# "data": { "action": "pause" },
> +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
> #
> ##
> { 'event': 'GUEST_PANICKED',
> @@ -446,7 +447,8 @@
> # Example:
> #
> # <- { "event": "GUEST_CRASHLOADED",
> -# "data": { "action": "run" } }
> +# "data": { "action": "run" },
> +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
> #
> ##
> { 'event': 'GUEST_CRASHLOADED',
> --
> 2.35.1
>
Someone once reviewed my documentation and noted that the timestamps
were correctly chronological.
... I feel like I have been *hurt* somehow.
Anyway:
Reviewed-by: John Snow <jsnow@redhat.com>
- Re: [PATCH 07/14] qapi: fix example of UNPLUG_PRIMARY event, (continued)
- [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/24
- [PATCH 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/24
- [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/24
- [PATCH 10/14] qapi: run-state examples: add missing timestamp, Victor Toso, 2022/03/24
- Re: [PATCH 10/14] qapi: run-state examples: add missing timestamp,
John Snow <=
- [PATCH 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/24
- [PATCH 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/24
- [PATCH 14/14] qapi: fix example of dump-guest-memory, Victor Toso, 2022/03/24
- [PATCH 12/14] qapi: ui examples: add missing websocket member, Victor Toso, 2022/03/24