[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event |
|
Date: |
Thu, 24 Mar 2022 17:31:05 -0400 |
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote:
>
> * Missing the timestamp
> * Missing the "info" object in the "data" member
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/acpi.json | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/acpi.json b/qapi/acpi.json
> index 51f0d55db7..d148f6db9f 100644
> --- a/qapi/acpi.json
> +++ b/qapi/acpi.json
> @@ -133,8 +133,9 @@
> # Example:
> #
> # <- { "event": "ACPI_DEVICE_OST",
> -# "data": { "device": "d1", "slot": "0",
> -# "slot-type": "DIMM", "source": 1, "status": 0 } }
> +# "data": { "info": { "device": "d1", "slot": "0",
> +# "slot-type": "DIMM", "source": 1, "status": 0 } },
> +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
> { 'event': 'ACPI_DEVICE_OST',
> --
> 2.35.1
>
Oh, good spot.
Reviewed-by: John Snow <jsnow@redhat.com>
- Re: [PATCH 04/14] qapi: fix example of BLOCK_JOB_PENDING event, (continued)
- [PATCH 09/14] qapi: run-state examples: add missing member, Victor Toso, 2022/03/24
- [PATCH 03/14] qapi: fix example of BLOCK_IO_ERROR event, Victor Toso, 2022/03/24
- [PATCH 07/14] qapi: fix example of UNPLUG_PRIMARY event, Victor Toso, 2022/03/24
- [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/24
- Re: [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event,
John Snow <=
- [PATCH 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/24
- [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/24
- [PATCH 10/14] qapi: run-state examples: add missing timestamp, Victor Toso, 2022/03/24
- [PATCH 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/24